potsda.mn/mastodon
5
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Revert "Wrap methods of ProcessFeedService::ProcessEntry in classes (#4151)" (#4157)

Browse source 
This reverts commit 425acecfdb.
This commit is contained in:
nightpool 2017-07-11 12:19:16 -04:00 committed by Eugen Rochko
parent e6c81a635b
commit 1c6c6b271c
1 changed files with 208 additions and 225 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

433
app/services/process_feed_service.rb
View file

@ -22,285 +22,268 @@ class ProcessFeedService < BaseService
class ProcessEntry class ProcessEntry
def call(xml, account) def call(xml, account)
@account = account @account = account
@fetched = Activity.new(xml) @xml = xml
return unless [:activity, :note, :comment].include?(@fetched.type) return if skip_unsupported_type?
klass = case @fetched.verb case verb
when :post when :post, :share
PostActivity return create_status
when :share when :delete
ShareActivity return delete_status
when :delete end
DeletionActivity
else
return
end
@fetched = klass.new(xml, account)
@fetched.perform
rescue ActiveRecord::RecordInvalid => e rescue ActiveRecord::RecordInvalid => e
Rails.logger.debug "Nothing was saved for #{id} because: #{e}" Rails.logger.debug "Nothing was saved for #{id} because: #{e}"
nil nil
end end
class Activity private
def initialize(xml, account = nil)
@xml = xml def create_status
@account = account if redis.exists("delete_upon_arrival:#{@account.id}:#{id}")
Rails.logger.debug "Delete for status #{id} was queued, ignoring"
return
end end
def verb status, just_created = nil
raw = @xml.at_xpath('./activity:verb', activity: TagManager::AS_XMLNS).content
TagManager::VERBS.key(raw) Rails.logger.debug "Creating remote status #{id}"
rescue
:post if verb == :share
original_status = shared_status_from_xml(@xml.at_xpath('.//activity:object', activity: TagManager::AS_XMLNS))
return nil if original_status.nil?
end end
def type ApplicationRecord.transaction do
raw = @xml.at_xpath('./activity:object-type', activity: TagManager::AS_XMLNS).content status, just_created = status_from_xml(@xml)
TagManager::TYPES.key(raw)
rescue
:activity
end
def id return if status.nil?
@xml.at_xpath('./xmlns:id', xmlns: TagManager::XMLNS).content return status unless just_created
end
def url if verb == :share
link = @xml.at_xpath('./xmlns:link[@rel="alternate"]', xmlns: TagManager::XMLNS) status.reblog = original_status.reblog? ? original_status.reblog : original_status
link.nil? ? nil : link['href']
end
private
def find_status(uri)
if TagManager.instance.local_id?(uri)
local_id = TagManager.instance.unique_tag_to_local_id(uri, 'Status')
return Status.find_by(id: local_id)
end end
Status.find_by(uri: uri) status.save!
end end
def redis if thread?(@xml) && status.thread.nil?
Redis.current Rails.logger.debug "Trying to attach #{status.id} (#{id(@xml)}) to #{thread(@xml).first}"
ThreadResolveWorker.perform_async(status.id, thread(@xml).second)
end
notify_about_mentions!(status) unless status.reblog?
notify_about_reblog!(status) if status.reblog? && status.reblog.account.local?
Rails.logger.debug "Queuing remote status #{status.id} (#{id}) for distribution"
LinkCrawlWorker.perform_async(status.id) unless status.spoiler_text?
DistributionWorker.perform_async(status.id)
status
end
def notify_about_mentions!(status)
status.mentions.includes(:account).each do |mention|
mentioned_account = mention.account
next unless mentioned_account.local?
NotifyService.new.call(mentioned_account, mention)
end end
end end
class CreationActivity < Activity def notify_about_reblog!(status)
def perform NotifyService.new.call(status.reblog.account, status)
if redis.exists("delete_upon_arrival:#{@account.id}:#{id}") end
Rails.logger.debug "Delete for status #{id} was queued, ignoring"
return
end
Rails.logger.debug "Creating remote status #{id}" def delete_status
# Return early if status already exists in db Rails.logger.debug "Deleting remote status #{id}"
status = find_status(id) status = Status.find_by(uri: id, account: @account)
return [status, false] unless status.nil? if status.nil?
redis.setex("delete_upon_arrival:#{@account.id}:#{id}", 6 * 3_600, id)
else
RemoveStatusService.new.call(status)
end
end
return [nil, false] if @account.suspended? def skip_unsupported_type?
!([:post, :share, :delete].include?(verb) && [:activity, :note, :comment].include?(type))
end
status = Status.create!( def shared_status_from_xml(entry)
uri: id, status = find_status(id(entry))
url: url,
account: @account,
reblog: reblog,
text: content,
spoiler_text: content_warning,
created_at: published,
reply: thread?,
language: content_language,
visibility: visibility_scope,
conversation: converstation_to_persistent&.first,
thread: thread? ? find_status(thread.first) : nil
)
save_mentions(status) return status unless status.nil?
save_hashtags(status)
save_media(status)
if thread? && status.thread.nil? FetchRemoteStatusService.new.call(url(entry))
Rails.logger.debug "Trying to attach #{status.id} (#{id}) to #{thread.first}" end
ThreadResolveWorker.perform_async(status.id, thread.second)
end
Rails.logger.debug "Queuing remote status #{status.id} (#{id}) for distribution" def status_from_xml(entry)
# Return early if status already exists in db
status = find_status(id(entry))
LinkCrawlWorker.perform_async(status.id) unless status.spoiler_text? return [status, false] unless status.nil?
DistributionWorker.perform_async(status.id)
[status, true] account = @account
return [nil, false] if account.suspended?
status = Status.create!(
uri: id(entry),
url: url(entry),
account: account,
text: content(entry),
spoiler_text: content_warning(entry),
created_at: published(entry),
reply: thread?(entry),
language: content_language(entry),
visibility: visibility_scope(entry),
conversation: find_or_create_conversation(entry),
thread: thread?(entry) ? find_status(thread(entry).first) : nil
)
mentions_from_xml(status, entry)
hashtags_from_xml(status, entry)
media_from_xml(status, entry)
[status, true]
end
def find_or_create_conversation(xml)
uri = xml.at_xpath('./ostatus:conversation', ostatus: TagManager::OS_XMLNS)&.attribute('ref')&.content
return if uri.nil?
if TagManager.instance.local_id?(uri)
local_id = TagManager.instance.unique_tag_to_local_id(uri, 'Conversation')
return Conversation.find_by(id: local_id)
end end
def content Conversation.find_by(uri: uri) || Conversation.create!(uri: uri)
@xml.at_xpath('./xmlns:content', xmlns: TagManager::XMLNS).content end
def find_status(uri)
if TagManager.instance.local_id?(uri)
local_id = TagManager.instance.unique_tag_to_local_id(uri, 'Status')
return Status.find_by(id: local_id)
end end
def content_language Status.find_by(uri: uri)
@xml.at_xpath('./xmlns:content', xmlns: TagManager::XMLNS)['xml:lang']&.presence || 'en' end
def mentions_from_xml(parent, xml)
processed_account_ids = []
xml.xpath('./xmlns:link[@rel="mentioned"]', xmlns: TagManager::XMLNS).each do |link|
next if [TagManager::TYPES[:group], TagManager::TYPES[:collection]].include? link['ostatus:object-type']
mentioned_account = account_from_href(link['href'])
next if mentioned_account.nil? || processed_account_ids.include?(mentioned_account.id)
mentioned_account.mentions.where(status: parent).first_or_create(status: parent)
# So we can skip duplicate mentions
processed_account_ids << mentioned_account.id
end end
end
def content_warning def account_from_href(href)
@xml.at_xpath('./xmlns:summary', xmlns: TagManager::XMLNS)&.content || '' url = Addressable::URI.parse(href).normalize
if TagManager.instance.web_domain?(url.host)
Account.find_local(url.path.gsub('/users/', ''))
else
Account.where(uri: href).or(Account.where(url: href)).first || FetchRemoteAccountService.new.call(href)
end end
end
def visibility_scope def hashtags_from_xml(parent, xml)
@xml.at_xpath('./mastodon:scope', mastodon: TagManager::MTDN_XMLNS)&.content&.to_sym || :public tags = xml.xpath('./xmlns:category', xmlns: TagManager::XMLNS).map { |category| category['term'] }.select(&:present?)
end ProcessHashtagsService.new.call(parent, tags)
end
def published def media_from_xml(parent, xml)
@xml.at_xpath('./xmlns:published', xmlns: TagManager::XMLNS).content do_not_download = DomainBlock.find_by(domain: parent.account.domain)&.reject_media?
end
def thread? xml.xpath('./xmlns:link[@rel="enclosure"]', xmlns: TagManager::XMLNS).each do |link|
!@xml.at_xpath('./thr:in-reply-to', thr: TagManager::THR_XMLNS).nil? next unless link['href']
end
def thread media = MediaAttachment.where(status: parent, remote_url: link['href']).first_or_initialize(account: parent.account, status: parent, remote_url: link['href'])
thr = @xml.at_xpath('./thr:in-reply-to', thr: TagManager::THR_XMLNS) parsed_url = Addressable::URI.parse(link['href']).normalize
[thr['ref'], thr['href']]
end
private next if !%w(http https).include?(parsed_url.scheme) || parsed_url.host.empty?
def converstation_to_persistent media.save
uri = @xml.at_xpath('./ostatus:conversation', ostatus: TagManager::OS_XMLNS)&.attribute('ref')&.content
return if uri.nil?
if TagManager.instance.local_id?(uri) next if do_not_download
local_id = TagManager.instance.unique_tag_to_local_id(uri, 'Conversation')
return Conversation.find_by(id: local_id)
end
found = Conversation.find_by(uri: uri) begin
found ? [found, false] : [Conversation.create!(uri: uri), true] media.file_remote_url = link['href']
end media.save!
rescue ActiveRecord::RecordInvalid
def save_mentions(parent) next
processed_account_ids = []
@xml.xpath('./xmlns:link[@rel="mentioned"]', xmlns: TagManager::XMLNS).each do |link|
next if [TagManager::TYPES[:group], TagManager::TYPES[:collection]].include? link['ostatus:object-type']
mentioned_account = account_from_href(link['href'])
next if mentioned_account.nil? || processed_account_ids.include?(mentioned_account.id)
mentioned_account.mentions.where(status: parent).first_or_create(status: parent)
# So we can skip duplicate mentions
processed_account_ids << mentioned_account.id
end
end
def save_hashtags(parent)
tags = @xml.xpath('./xmlns:category', xmlns: TagManager::XMLNS).map { |category| category['term'] }.select(&:present?)
ProcessHashtagsService.new.call(parent, tags)
end
def save_media(parent)
do_not_download = DomainBlock.find_by(domain: parent.account.domain)&.reject_media?
@xml.xpath('./xmlns:link[@rel="enclosure"]', xmlns: TagManager::XMLNS).each do |link|
next unless link['href']
media = MediaAttachment.where(status: parent, remote_url: link['href']).first_or_initialize(account: parent.account, status: parent, remote_url: link['href'])
parsed_url = Addressable::URI.parse(link['href']).normalize
next if !%w(http https).include?(parsed_url.scheme) || parsed_url.host.empty?
media.save
next if do_not_download
begin
media.file_remote_url = link['href']
media.save!
rescue ActiveRecord::RecordInvalid
next
end
end
end
def account_from_href(href)
url = Addressable::URI.parse(href).normalize
if TagManager.instance.web_domain?(url.host)
Account.find_local(url.path.gsub('/users/', ''))
else
Account.where(uri: href).or(Account.where(url: href)).first || FetchRemoteAccountService.new.call(href)
end end
end end
end end
class ShareActivity < CreationActivity def id(xml = @xml)
def perform xml.at_xpath('./xmlns:id', xmlns: TagManager::XMLNS).content
status, just_created = super
NotifyService.new.call(reblog.account, status) if reblog&.account&.local? && just_created
status
end
def object
@xml.at_xpath('.//activity:object', activity: TagManager::AS_XMLNS)
end
private
def status
reblog && super
end
def reblog
return @reblog if defined? @reblog
original_status = RemoteActivity.new(object).perform
@reblog = original_status.reblog? ? original_status.reblog : original_status
end
end end
class PostActivity < CreationActivity def verb(xml = @xml)
def perform raw = xml.at_xpath('./activity:verb', activity: TagManager::AS_XMLNS).content
status, just_created = super TagManager::VERBS.key(raw)
rescue
if just_created :post
status.mentions.includes(:account).each do |mention|
mentioned_account = mention.account
next unless mentioned_account.local?
NotifyService.new.call(mentioned_account, mention)
end
end
status
end
private
def reblog
nil
end
end end
class DeletionActivity < Activity def type(xml = @xml)
def perform raw = xml.at_xpath('./activity:object-type', activity: TagManager::AS_XMLNS).content
Rails.logger.debug "Deleting remote status #{id}" TagManager::TYPES.key(raw)
status = Status.find_by(uri: id, account: @account) rescue
:activity
if status.nil?
redis.setex("delete_upon_arrival:#{@account.id}:#{id}", 6 * 3_600, id)
else
RemoveStatusService.new.call(status)
end
end
end end
class RemoteActivity < Activity def url(xml = @xml)
def perform link = xml.at_xpath('./xmlns:link[@rel="alternate"]', xmlns: TagManager::XMLNS)
find_status(id) || FetchRemoteStatusService.new.call(url) link.nil? ? nil : link['href']
end end
def content(xml = @xml)
xml.at_xpath('./xmlns:content', xmlns: TagManager::XMLNS).content
end
def content_language(xml = @xml)
xml.at_xpath('./xmlns:content', xmlns: TagManager::XMLNS)['xml:lang']&.presence || 'en'
end
def content_warning(xml = @xml)
xml.at_xpath('./xmlns:summary', xmlns: TagManager::XMLNS)&.content || ''
end
def visibility_scope(xml = @xml)
xml.at_xpath('./mastodon:scope', mastodon: TagManager::MTDN_XMLNS)&.content&.to_sym || :public
end
def published(xml = @xml)
xml.at_xpath('./xmlns:published', xmlns: TagManager::XMLNS).content
end
def thread?(xml = @xml)
!xml.at_xpath('./thr:in-reply-to', thr: TagManager::THR_XMLNS).nil?
end
def thread(xml = @xml)
thr = xml.at_xpath('./thr:in-reply-to', thr: TagManager::THR_XMLNS)
[thr['ref'], thr['href']]
end
def account?(xml = @xml)
!xml.at_xpath('./xmlns:author', xmlns: TagManager::XMLNS).nil?
end
def redis
Redis.current
end end
end end
end end