potsda.mn/mastodon
5
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Error responses cleanup (#2692)

Browse source 
* Use respond_with_error for forbidden errors

* Wrap up common error code into single method
This commit is contained in:
Matt Jankowski 2017-05-01 16:24:36 -04:00 committed by Eugen Rochko
parent 2bd46f442d
commit 7bffd16024
1 changed files with 14 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
app/controllers/application_controller.rb
View file

@ -44,32 +44,20 @@ class ApplicationController < ActionController::Base
protected
def forbidden
respond_with_error(403)
end
def not_found
respond_to do |format|
format.any { head 404 }
format.html { respond_with_error(404) }
end
respond_with_error(404)
end
def gone
respond_to do |format|
format.any { head 410 }
format.html { respond_with_error(410) }
end
end
def forbidden
respond_to do |format|
format.any { head 403 }
format.html { render 'errors/403', layout: 'error', status: 403 }
end
respond_with_error(410)
end
def unprocessable_entity
respond_to do |format|
format.any { head 422 }
format.html { respond_with_error(422) }
end
respond_with_error(422)
end
def single_user_mode?
@ -105,7 +93,12 @@ class ApplicationController < ActionController::Base
end
def respond_with_error(code)
set_locale
render "errors/#{code}", layout: 'error', status: code
respond_to do |format|
format.any { head code }
format.html do
set_locale
render "errors/#{code}", layout: 'error', status: code
end
end
end
end