potsda.mn/mastodon
5
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Improve performance by avoiding method cache busts (#19957)

Browse source 
Switch to monkey-patching http.rb rather than a runtime extend of each
response, so as to avoid busting the global method cache. A guard is
included that will provide developer feedback in development and test
environments should the monkey patch ever collide.
This commit is contained in:
James Tucker 2022-11-07 19:00:27 -08:00 committed by GitHub
parent 9f4930ec11
commit 833d9c2f1c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
app/lib/request.rb
View file

@ -62,8 +62,6 @@ class Request
end end
begin begin
response = response.extend(ClientLimit)
# If we are using a persistent connection, we have to # If we are using a persistent connection, we have to
# read every response to be able to move forward at all. # read every response to be able to move forward at all.
# However, simply calling #to_s or #flush may not be safe, # However, simply calling #to_s or #flush may not be safe,
@ -181,6 +179,14 @@ class Request
end end
end end
if ::HTTP::Response.methods.include?(:body_with_limit) && !Rails.env.production?
abort 'HTTP::Response#body_with_limit is already defined, the monkey patch will not be applied'
else
class ::HTTP::Response
include Request::ClientLimit
end
end
class Socket < TCPSocket class Socket < TCPSocket
class << self class << self
def open(host, *args) def open(host, *args)