Commit graph

2136 commits

Author SHA1 Message Date
Matt Jankowski 1b0cb3b54d
Announcement reactions query spec improvement and refactor () 2024-01-17 09:18:13 +00:00
Matt Jankowski b4c332104a
Use top-level warn in JS errors check () 2024-01-15 21:26:11 +00:00
Claire 98b5f85f10
Rename and refactor User#confirm! to User#mark_email_as_confirmed! () 2024-01-15 18:04:58 +00:00
Claire e621c1c44c
Fix registrations not checking MX records for email domain blocks requiring approval () 2024-01-15 17:10:57 +00:00
Matt Jankowski a2f02a0775
Disable Rails/SkipsModelValidations cop () 2024-01-15 13:46:47 +00:00
Matt Jankowski e72676e83a
Improve api/v1/markers#create performance against simultaneous requests () 2024-01-15 09:47:25 +00:00
MitarashiDango 2c05b8a60d
Fix Undo Announce activity is not sent, when not followed by the reblogged post author ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2024-01-12 15:58:28 +00:00
Matt Jankowski a90696011e
Add coverage/bugfix for invalid appeal submission () 2024-01-12 09:21:00 +00:00
Matt Jankowski 7801db7ba4
Spec coverage for custom css endpoint () 2024-01-12 09:19:25 +00:00
Matt Jankowski df9e220364
Add JS console errors check () 2024-01-12 09:12:31 +00:00
Matt Jankowski cd37048439
Move followable_by coverage to suggestions () 2024-01-12 09:11:34 +00:00
Matt Jankowski 32eeca9c7b
Refresh instance counts in spec (fixes intermittent failure) () 2024-01-12 09:10:37 +00:00
Matt Jankowski 8b26614fa7
Combine results include check in spec/models/account () 2024-01-11 16:17:45 +00:00
Matt Jankowski 185c806d69
Extract spec helper for verifing to/from public AP collection namespace () 2024-01-11 16:17:21 +00:00
Matt Jankowski 2954279e9c
Remove double subject call in api/v1/admin/trends/links/links spec () 2024-01-11 15:13:11 +00:00
Matt Jankowski 95bd46d32a
Remove double subject call in api/v1/admin/ip_blocks spec () 2024-01-11 15:11:57 +00:00
Matt Jankowski 4e08a4892f
Move streaming around config into manager class () 2024-01-11 10:54:42 +00:00
Matt Jankowski 87097a227c
Clean up settings/featured_tags/index view () 2024-01-11 10:45:26 +00:00
Matt Jankowski 55802242ce
Refactor login activity partial (remove inline ruby) () 2024-01-11 10:36:27 +00:00
Matt Jankowski 0a7cff53c2
Add coverage for Account.followable_by scope () 2024-01-11 09:30:29 +00:00
Claire d7e13e2483
Fix potential redirection loop of streaming endpoint () 2024-01-10 15:05:46 +00:00
Matt Jankowski 8422b8ded0
Extract capybara config and improve headless_chrome driver config () 2024-01-10 14:54:11 +00:00
Matt Jankowski 543d7890fd
Use normalizes to prepare User values ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2024-01-10 13:36:06 +00:00
Matt Jankowski 00341c70ff
Use Sidekiq fake! instead of inline! in specs () 2024-01-10 11:06:58 +00:00
Matt Jankowski 742d8d30e2
Add coverage for --days option to CLI media refresh command () 2024-01-10 09:36:12 +00:00
Renaud Chaput 63d0b52cf3
Add a system spec for the /share endpoint () 2024-01-09 21:58:19 +00:00
Claire 10203bd57a
Clean up Setting model and remove dead code () 2024-01-09 14:01:53 +00:00
Jean Boussier 1781849884
Inline what remains of the rails-settings-cached gem ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2024-01-09 11:50:21 +00:00
Matt Jankowski 5dc634796a
Misc coverage improvements re: sidekiq/inline () 2024-01-09 09:40:08 +00:00
Matt Jankowski e677eb164c
Remove unused Announcement#time_range? () 2024-01-08 15:26:30 +00:00
Matt Jankowski 3e43cd095c
Remove unused scope Announcement.without_muted () 2024-01-08 15:26:14 +00:00
Claire 157fc69954
Make request_pool_spec tests more robust () 2024-01-08 12:29:05 +00:00
Matt Jankowski aa6d07dbd9
Use normalizes to prepare CustomEmoji domain value () 2024-01-08 11:20:59 +00:00
Matt Jankowski 832b92ac3e
Add attachment check to spec/service/suspend_account_service spec () 2024-01-08 11:05:10 +00:00
Matt Jankowski 12bed81187
Add validation specs to CustomFilter model () 2024-01-05 15:13:59 +00:00
Claire 6ad0fb5a77
Fix NULL MX handling and tighten DNS resolving specs () 2024-01-05 11:07:57 +00:00
Claire 5f4643b895
Add PAPERCLIP_ROOT_URL to Content-Security-Policy when used () 2024-01-05 10:45:36 +00:00
Matt Jankowski 964a0ecf37
Add sleep statement to nudge thread scheduler in request pool spec () 2024-01-04 16:55:00 +00:00
Matt Jankowski f06c1f1552
Fix Capybara/ClickLinkOrButtonStyle cop in spec/features () 2024-01-04 09:20:32 +00:00
Claire dfdadb92e8
Add ability to require approval when users sign up using specific email domains () 2024-01-04 09:07:05 +00:00
Matt Jankowski f92d8c654d
Standardize on Thor methods in CLI classes () 2024-01-03 15:08:08 +00:00
Matt Jankowski 5c769de096
Add spec coverage for CLI::Media#remove_orphans command () 2024-01-03 14:12:56 +00:00
Matt Jankowski 74a0d81e90
Add coverage for CLI self-destruct command ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2024-01-03 13:06:38 +00:00
Claire 092bb8a27a
Fix Mastodon not correctly processing HTTP Signatures with query strings () 2024-01-03 11:29:26 +00:00
Claire bd415af9a1
Change streaming API host to not be overridden to localhost in development mode () 2024-01-03 10:23:58 +00:00
Claire a2624ff739
Convert signature verification specs to request specs () 2023-12-22 18:56:22 +00:00
Matt Jankowski bb8077e784
Fix RSpec/LetSetup cop in models/account_status_cleanup_policy () 2023-12-22 15:29:50 +00:00
Claire 2bf84b93d4
Fix media attachment order of remote posts () 2023-12-22 15:10:39 +00:00
Matt Jankowski a4d49c236d
Fix RSpec/LetSetup cop in ap/fetch_featured_collection_service () 2023-12-22 12:57:29 +00:00
Matt Jankowski e6e217fedd
Clean up tagged_with_* Status specs, fix RSpec/LetSetup cop () 2023-12-22 08:32:27 +00:00
Matt Jankowski 513d35969e
Fix RSpec/LetSetup cop in auth controller specs () 2023-12-22 08:03:59 +00:00
Matt Jankowski 9251779d75
Fix RSpec/LetSetup cop in spec/services () 2023-12-21 14:23:53 +00:00
Matt Jankowski efd16f3c2c
Clean up of RSpec/LetSetup within spec/services/activitypub () 2023-12-21 11:20:12 +00:00
Matt Jankowski c99f88e1a8
Clean up of RSpec/LetSetup within spec/lib () 2023-12-21 11:19:56 +00:00
Matt Jankowski cd64a5b2ec
Clean up of RSpec/LetSetup within api/ () 2023-12-21 10:10:18 +00:00
Matt Jankowski f32d672d2f
Clean up of RSpec/LetSetup within spec/controllers () 2023-12-21 09:28:41 +00:00
Matt Jankowski c753b1ad35
Clean up of RSpec/LetSetup within spec/models () 2023-12-21 09:18:38 +00:00
Matt Jankowski 2463b53363
More duplicates in cli maintenance spec, misc bug fixes () 2023-12-21 08:51:03 +00:00
Matt Jankowski 961d65aba6
Add coverage to CLI Maintenance for duplicate users on confirmation_token and reset_password_token values () 2023-12-20 08:54:04 +00:00
Claire 6fed0fcbaa
Remove unneeded settings cleanup from specs () 2023-12-19 15:17:22 +00:00
Matt Jankowski c7c727994a
Add spec for CLI::Maintenance#fix_duplicates () 2023-12-19 13:10:33 +00:00
Eugen Rochko b5ac61b2c5
Change algorithm of follow recommendations ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2023-12-19 10:59:43 +00:00
Matt Jankowski c28976d89e
Handle negative offset param in api/v2/search () 2023-12-19 10:55:39 +00:00
Matt Jankowski 476d1237d4
Typo fix in json ld helper spec () 2023-12-18 16:47:22 +00:00
Claire 7d9b209fe8
Fix call to inefficient delete_matched cache method in domain blocks () 2023-12-18 16:14:43 +00:00
Matt Jankowski af366f65ee
Add spec coverage for models/form/custom_emoji_batch class () 2023-12-18 12:41:37 +00:00
Matt Jankowski 1820bad646
Fix Performance/StringIdentifierArgument cop () 2023-12-18 10:26:09 +00:00
Matt Jankowski b1dec09d20
Fix Style/InverseMethods cop () 2023-12-15 15:52:00 +00:00
Matt Jankowski db897eaa5a
Unwind map on single-item array in spec/services/delete_account_service spec () 2023-12-14 14:07:54 +00:00
Matt Jankowski ef9797a395
Un-nest contexts in settings/2fa/webauthn spec () 2023-12-14 10:46:43 +00:00
Matt Jankowski adbfd40a1b
Convert api/v1/directories controller spec to request spec () 2023-12-14 10:38:06 +00:00
Matt Jankowski 28e1a7a394
Improve spec coverage for models/announcement class () 2023-12-14 10:29:10 +00:00
Matt Jankowski 8a3d8c6c14
Remove the stub_stdout wrapper around CLI specs () 2023-12-13 10:14:19 +00:00
Claire 89a496b42f
Fix status edits not always being streamed to mentioned users () 2023-12-12 10:39:21 +00:00
Matt Jankowski b5a1013ae3
Combine CLI::... spec example subjects () 2023-12-11 10:23:45 +00:00
Matt Jankowski 0e4233de9d
Controller spec to request spec: api/v2/suggestions () 2023-12-11 08:13:57 +00:00
Matt Jankowski 0c64092500
Controller spec to request spec: api/v1/accounts/search () 2023-12-11 08:13:28 +00:00
Matt Jankowski 16ede59d0a
Controller spec to request spec: api/v1/featured_tags/suggestions () 2023-12-11 08:00:41 +00:00
Matt Jankowski 809506bdd4
Controller spec to request spec: api/v1/accounts/pins () 2023-12-11 07:59:40 +00:00
Matt Jankowski 94cc707ab3
Controller spec to request spec: api/v1/accounts/notes () 2023-12-11 07:58:48 +00:00
Matt Jankowski e544b6df42
Controller spec to request spec: api/v1/accounts/lookup () 2023-12-11 07:57:33 +00:00
Matt Jankowski a968898dc7
Controller spec to request spec: api/v1/accounts/lists () 2023-12-11 07:56:47 +00:00
Matt Jankowski 8f94502e7d
Controller spec to request spec: api/v1/accounts/identify_proofs () 2023-12-11 07:56:13 +00:00
Matt Jankowski 78347d2556
Controller spec to request spec: api/v1/accounts/familiar_followers () 2023-12-11 07:55:45 +00:00
Matt Jankowski 11d2bd9716
Fix intermittent failure from unspecified order in api/v1/accounts/relationships spec () 2023-12-11 07:55:07 +00:00
Matt Jankowski a3cbb4b2f1
Add spec for CLI::Search#deploy command () 2023-12-08 13:54:20 +00:00
Matt Jankowski 8de86eabbf
Add spec for CLI::Domains#crawl command () 2023-12-08 09:51:57 +00:00
Matt Jankowski 7e514688b3
Convert api/v2/search controller spec to request spec () 2023-12-08 09:27:33 +00:00
Matt Jankowski 8d8ae05a18
Add spec coverage for CLI::Media#lookup command () 2023-12-07 15:27:41 +00:00
Matt Jankowski ad34d33bfd
Formalize some patterns in cli specs () 2023-12-07 13:49:14 +00:00
Matt Jankowski 0b4a3a0437
Remove remaining without_partial_double_verification usage () 2023-12-07 12:15:50 +00:00
Claire 658ad7a6ca
Fix flaky tests related to file creation () 2023-12-06 22:22:25 +00:00
Matt Jankowski 0e8ba19113
Add spec coverage for CLI::Emoji class () 2023-12-06 08:52:30 +00:00
Matt Jankowski ed7b5c091b
Remove double subject call in services/delete_account_service spec () 2023-12-06 08:51:09 +00:00
Matt Jankowski be6bb1a10d
Remove double subject call in services/suspend_account_service spec () 2023-12-06 08:45:19 +00:00
Matt Jankowski 5517df61de
Remove double subject call in services/activitypub/process_account_service spec () 2023-12-06 08:44:51 +00:00
Matt Jankowski faffd81976
Remove double subject call in services/unsuspend_account_service spec () 2023-12-06 08:44:07 +00:00
Matt Jankowski 89a8e6e622
Remove 2x double subject call in models/form/account_batch spec () 2023-12-04 15:41:43 +00:00
Matt Jankowski 71e5a16eba
Remove triple subject call in api/v1/lists spec () 2023-12-04 15:28:19 +00:00
Matt Jankowski cca19f5fbb
Use the Admin::ActionLog fabricator in admin/action_logs spec () 2023-12-04 12:56:28 +00:00
Matt Jankowski b3b009e6aa
Add spec coverage for CLI::EmailDomainBlocks commands () 2023-12-04 09:44:54 +00:00
Matt Jankowski 9603198982
Add spec coverage for CLI::Domains#purge command () 2023-12-04 09:09:05 +00:00
Matt Jankowski 1bf2230fd1
Add spec coverage for CLI::Upgrade#storage_schema command () 2023-12-04 09:08:47 +00:00
Matt Jankowski 19ad51253d
Prevent triple-subject run in admin/domain_blocks spec () 2023-12-04 09:02:40 +00:00
Matt Jankowski d848d8d87c
Add helper methods for domains allow and export blocks files () 2023-12-04 08:52:21 +00:00
Matt Jankowski 5631f139c1
Fix Lint/SymbolConversion cop () 2023-12-01 15:53:35 +00:00
Matt Jankowski aa8563d43d
Fix Style/SuperWithArgsParentheses cop () 2023-12-01 15:53:15 +00:00
Matt Jankowski 1564799952
Add spec coverage for media CLI refresh command () 2023-12-01 14:18:45 +00:00
Matt Jankowski 7753e5f715
Add shared example for CLI command specs () 2023-12-01 12:00:34 +00:00
Matt Jankowski 92fa9b109f
Add spec coverage for media CLI usage command () 2023-12-01 11:56:47 +00:00
Matt Jankowski 440b80b2e7
Model concerns organization into module namespaces () 2023-12-01 11:00:41 +00:00
Matt Jankowski b751078fcd
Eliminate double subject call in admin/ controller specs () 2023-12-01 10:38:15 +00:00
Matt Jankowski 1f1c75bba5
File cleanup/organization in controllers/concerns () 2023-11-30 14:39:41 +00:00
Matt Jankowski 0530ce5e95
Convert accounts controller spec to request spec () 2023-11-30 14:28:05 +00:00
Matt Jankowski e7c340a634
Spec coverage for missing q param and error conditions in api/v2/search controller () 2023-11-30 13:59:46 +00:00
Claire 85662a5a57
Change img-src and media-src CSP directives to not include https: () 2023-11-30 13:47:01 +00:00
Matt Jankowski bb0efe16e6
Remove default_scope from MediaAttachment class () 2023-11-30 13:30:35 +00:00
Matt Jankowski ce78a9c9ac
Clean up two_factor_authentication/confirmations controller spec () 2023-11-30 11:44:42 +00:00
Filippo Giunchedi e6fd9a59e6
Fix FamiliarFollowersController test response comparison ()
Co-authored-by: Filippo Giunchedi <filippo@debian.org>
2023-11-30 10:58:40 +00:00
Matt Jankowski e48ecd2929
Remove default_scope from Admin::ActionLog () 2023-11-29 10:39:59 +00:00
Matt Jankowski 291dc04e67
Remove un-needed action and template options to render in controllers () 2023-11-29 10:38:05 +00:00
Emelia Smith 603b245cc6
Add VAPID public key to instance serializer ()
Co-authored-by: Renaud Chaput <renchap@gmail.com>
2023-11-29 08:34:36 +00:00
Matt Jankowski 6b46bf9953
Handle scenario when webfinger response subject is missing host value () 2023-11-28 18:37:54 +00:00
Matt Jankowski 19baf22683
Add missing email previews for AdminMailer () 2023-11-23 12:32:50 +00:00
Kevin Bongart 7877fcd83c
Deduplicate IDs in relationships and familiar_followers APIs () 2023-11-23 10:00:09 +00:00
Matt Jankowski 973597c6f1
Consolidate configuration of Sidekiq::Testing.fake! setup () 2023-11-23 09:43:43 +00:00
Matt Jankowski 9742bccbe7
Add coverage for api/v2/media endpoint () 2023-11-22 15:39:34 +00:00
Eugen Rochko cdc57c74b7
Fix unsupported time zone or locale preventing sign-up ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2023-11-22 11:38:07 +00:00
Matt Jankowski 67fd3187b3
Update rspec fixture path config to silence deprecation warning () 2023-11-21 15:51:40 +00:00
Matt Jankowski 30ee4aaff4
Convert measurement api/v1/admin/* controller specs to request specs () 2023-11-21 14:25:07 +00:00
Matt Jankowski 32e19e3af6
Reduce .times usage in request and controller specs () 2023-11-21 13:05:59 +00:00
Matt Jankowski f7cb64a184
Add coverage for settings/privacy controller () 2023-11-21 13:02:37 +00:00
Matt Jankowski b2e8af8889
Add coverage for settings/verifications controller () 2023-11-21 11:00:22 +00:00
Matt Jankowski 6d51ac246b
Update partials for the AdminMailer.new_trends mailer () 2023-11-21 10:52:20 +00:00
Matt Jankowski a6d446e6a7
Add coverage for remote_interaction_helper () 2023-11-21 10:28:55 +00:00
Matt Jankowski 876f5b1d12
Convert /instances/* controller specs to request specs ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2023-11-20 11:05:28 +00:00
Matt Jankowski 718c95e7af
Convert api/v1/custom_emojis controller spec to request spec ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2023-11-20 11:05:24 +00:00
Claire c260a68f54
Clean up some Mastodon::CLI::Accounts tests () 2023-11-20 10:46:02 +00:00
Matt Jankowski 17582d36d5
Convert api/v1/preferences controller spec to request spec () 2023-11-20 09:39:45 +00:00
Matt Jankowski 9a01a260a0
Convert api/v1/scheduled_statuses controller spec to request spec () 2023-11-20 09:36:49 +00:00
Matt Jankowski b9fb47aeb1
Convert api/v1/endorsements controller spec to request spec () 2023-11-20 09:32:28 +00:00
Matt Jankowski 371f355719
Reduce .times usage in AccountStatusesCleanupPolicy () 2023-11-20 09:08:54 +00:00
Matt Jankowski d2aacea8da
Reduce .times usage in AccountSearch spec, use constant for default limit () 2023-11-20 09:08:22 +00:00
Matt Jankowski 00c6ebd86f
Reduce .times usage in StatusPin and add PIN_LIMIT constant in validator () 2023-11-20 09:07:25 +00:00
Matt Jankowski 1fabf20a88
Reduce .times usage in lib/mastodon/cli/accounts spec () 2023-11-20 09:04:46 +00:00
Matt Jankowski 09a2db3f6c
Move api/v2/filters spec to correct path location () 2023-11-20 08:48:56 +00:00
Matt Jankowski e892efbc40
Configure elastic search integration with rspec tag () 2023-11-17 11:52:20 +00:00
Claire 297839c10c
Rewrite /api/v1/statuses tests as request specs () 2023-11-17 11:36:04 +00:00
Claire 9257737675
Rewrite /api/v1/accounts tests as request specs () 2023-11-17 11:34:49 +00:00
Matt Jankowski 549e8e7baf
Add email_spec and speedup/cleanup to spec/mailers () 2023-11-17 09:50:19 +00:00