potsda.mn/mobilizon
10
4
Fork 1
Code Issues 22 Pull requests 1 Projects Releases Wiki Activity

fix(apps): fix typo in redirect_uri parameter

Browse source 
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
This commit is contained in:
Thomas Citharel 2023-05-30 11:48:07 +02:00
parent fa16537290
commit 5664625c1c
No known key found for this signature in database
GPG key ID: A061B9DDE0CA0773
3 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
.sobelow-skips
View file

@ -41,3 +41,4 @@ FE1EEB91EA633570F703B251AE2D4D4E
E7967805C1EA5301F2722C7BDB2F25F3 E7967805C1EA5301F2722C7BDB2F25F3
BDFB0FB1AAF69C18212CBCFD42F8B717 BDFB0FB1AAF69C18212CBCFD42F8B717
40220A533CCACB3A1CE9DBF1A8A430A1 40220A533CCACB3A1CE9DBF1A8A430A1
EEB29D1DDA3A3015BC645A989B5BD38E

6
lib/web/controllers/application_controller.ex
View file

@ -13,7 +13,7 @@ defmodule Mobilizon.Web.ApplicationController do
@spec create_application(Plug.Conn.t(), map()) :: Plug.Conn.t() @spec create_application(Plug.Conn.t(), map()) :: Plug.Conn.t()
def create_application( def create_application(
conn, conn,
%{"name" => name, "redirect_uris" => redirect_uris, "scope" => scope} = args %{"name" => name, "redirect_uri" => redirect_uris, "scope" => scope} = args
) do ) do
ip = conn.remote_ip |> :inet.ntoa() |> to_string() ip = conn.remote_ip |> :inet.ntoa() |> to_string()
@ -33,7 +33,9 @@ defmodule Mobilizon.Web.ApplicationController do
conn conn
|> Plug.Conn.put_resp_header("cache-control", "no-store") |> Plug.Conn.put_resp_header("cache-control", "no-store")
|> json( |> json(
Map.take(app, [:name, :website, :redirect_uris, :client_id, :client_secret, :scope]) app
|> Map.take([:name, :website, :client_id, :client_secret, :scope])
|> Map.put(:redirect_uri, app.redirect_uris)
) )
{:error, :invalid_scope} -> {:error, :invalid_scope} ->

6
test/web/controllers/application_controller_test.exs
View file

@ -24,7 +24,7 @@ defmodule Mobilizon.Web.ApplicationControllerTest do
conn conn
|> post("/apps", %{ |> post("/apps", %{
"name" => "hello", "name" => "hello",
"redirect_uris" => "hello", "redirect_uri" => "hello",
"scope" => "write nothing" "scope" => "write nothing"
}) })
@ -46,14 +46,14 @@ defmodule Mobilizon.Web.ApplicationControllerTest do
conn conn
|> post("/apps", %{ |> post("/apps", %{
"name" => name, "name" => name,
"redirect_uris" => Enum.join(redirect_uris, "\n"), "redirect_uri" => Enum.join(redirect_uris, "\n"),
"scope" => scope, "scope" => scope,
"website" => website "website" => website
}) })
assert %{ assert %{
"name" => ^name, "name" => ^name,
"redirect_uris" => ^redirect_uris, "redirect_uri" => ^redirect_uris,
"scope" => ^scope, "scope" => ^scope,
"website" => ^website, "website" => ^website,
"client_id" => _client_id, "client_id" => _client_id,