From d8dde92c864749d1455aaff67f8f79d4dcd2ee02 Mon Sep 17 00:00:00 2001
From: Chocobozzz <me@florianbigard.com>
Date: Fri, 28 Dec 2018 16:13:33 +0100
Subject: [PATCH 1/3] Fix user registration and validation

---
 js/src/components/Account/Register.vue | 32 ++++++++++++--------------
 js/src/components/Account/Validate.vue | 30 ++++++++++++------------
 js/src/graphql/user.ts                 | 11 ++-------
 lib/mobilizon/actors/actors.ex         |  8 ++++++-
 4 files changed, 39 insertions(+), 42 deletions(-)

diff --git a/js/src/components/Account/Register.vue b/js/src/components/Account/Register.vue
index d3010c55c..7108b9484 100644
--- a/js/src/components/Account/Register.vue
+++ b/js/src/components/Account/Register.vue
@@ -121,12 +121,9 @@
       },
     };
     rules = {
-      password_length: value => value.length > 6 || 'Password must be at least 6 caracters long',
+      password_length: value => value.length > 6 || 'Password must be at least 6 characters long',
       required: value => !!value || 'Required.',
-      email: (value) => {
-        const pattern = /^(([^<>()[\]\\.,;:\s@"]+(\.[^<>()[\]\\.,;:\s@"]+)*)|(".+"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/;
-        return pattern.test(value) || 'Invalid e-mail.';
-      },
+      email: (value: string) => value.indexOf('@') !== -1 || 'Invalid e-mail.',
     };
 
     resetState() {
@@ -154,20 +151,21 @@
       return this.rules.email(this.email) === true ? 'v-gravatar' : 'avatar';
     }
 
-    submit() {
-      this.$apollo.mutate({
-        mutation: CREATE_USER,
-        variables: {
-          email: this.email,
-          password: this.password,
-          username: this.username,
-        },
-      }).then((data) => {
-        console.log(data);
+    async submit() {
+      try {
+        await this.$apollo.mutate({
+          mutation: CREATE_USER,
+          variables: {
+            email: this.email,
+            password: this.password,
+            username: this.username,
+          },
+        });
+
         this.validationSent = true;
-      }).catch((error) => {
+      } catch (error) {
         console.error(error);
-      });
+      }
     }
   };
 </script>
diff --git a/js/src/components/Account/Validate.vue b/js/src/components/Account/Validate.vue
index 32815d7f5..a9d2a1f72 100644
--- a/js/src/components/Account/Validate.vue
+++ b/js/src/components/Account/Validate.vue
@@ -19,7 +19,7 @@
 <script lang="ts">
   import { VALIDATE_USER } from '@/graphql/user';
   import { Component, Prop, Vue } from 'vue-property-decorator';
-  import { AUTH_TOKEN, AUTH_USER_ACTOR, AUTH_USER_ID } from '@/constants';
+  import { AUTH_TOKEN, AUTH_USER_ID } from '@/constants';
 
   @Component
   export default class Validate extends Vue {
@@ -32,27 +32,27 @@
       this.validateAction();
     }
 
-    validateAction() {
-      this.$apollo.mutate({
-        mutation: VALIDATE_USER,
-        variables: {
-          token: this.token,
-        },
-      }).then((data) => {
-        this.loading = false;
-        console.log(data);
+    async validateAction() {
+      try {
+        const data = await this.$apollo.mutate({
+          mutation: VALIDATE_USER,
+          variables: {
+            token: this.token,
+          },
+        });
+
         this.saveUserData(data.data);
         this.$router.push({ name: 'Home' });
-      }).catch((error) => {
-        this.loading = false;
-        console.log(error);
+      } catch (err) {
+        console.error(err);
         this.failed = true;
-      });
+      } finally {
+        this.loading = false;
+      }
     }
 
     saveUserData({ validateUser: login }) {
       localStorage.setItem(AUTH_USER_ID, login.user.id);
-      localStorage.setItem(AUTH_USER_ACTOR, JSON.stringify(login.actor));
       localStorage.setItem(AUTH_TOKEN, login.token);
     }
 
diff --git a/js/src/graphql/user.ts b/js/src/graphql/user.ts
index b489b8206..4c714fbf3 100644
--- a/js/src/graphql/user.ts
+++ b/js/src/graphql/user.ts
@@ -3,11 +3,8 @@ import gql from 'graphql-tag';
 export const CREATE_USER = gql`
 mutation CreateUser($email: String!, $username: String!, $password: String!) {
   createUser(email: $email, username: $username, password: $password) {
-    preferredUsername,
-    user {
-      email,
-      confirmationSentAt
-    }
+    email,
+    confirmationSentAt
   }
 }
 `;
@@ -18,10 +15,6 @@ mutation ValidateUser($token: String!) {
     token,
     user {
       id,
-    },
-    actor {
-      avatarUrl,
-      preferredUsername,
     }
   }
 }
diff --git a/lib/mobilizon/actors/actors.ex b/lib/mobilizon/actors/actors.ex
index 0b6a30696..c599e9824 100644
--- a/lib/mobilizon/actors/actors.ex
+++ b/lib/mobilizon/actors/actors.ex
@@ -61,7 +61,13 @@ defmodule Mobilizon.Actors do
   """
   @spec get_actor_for_user(Mobilizon.Actors.User.t()) :: Mobilizon.Actors.Actor.t()
   def get_actor_for_user(%Mobilizon.Actors.User{} = user) do
-    case Repo.one(from(a in Actor, join: u in User, on: u.default_actor_id == a.id)) do
+    case Repo.one(
+           from(a in Actor,
+             join: u in User,
+             on: u.default_actor_id == a.id,
+             where: u.id == ^user.id
+           )
+         ) do
       nil -> get_actors_for_user(user) |> hd
       actor -> actor
     end

From 03535246a449370134197d2e1a2f2a113baef68d Mon Sep 17 00:00:00 2001
From: Chocobozzz <me@florianbigard.com>
Date: Fri, 28 Dec 2018 16:17:34 +0100
Subject: [PATCH 2/3] Fix login

---
 js/src/components/Account/Login.vue | 28 ++++++++++++++--------------
 js/src/graphql/auth.ts              |  4 ----
 2 files changed, 14 insertions(+), 18 deletions(-)

diff --git a/js/src/components/Account/Login.vue b/js/src/components/Account/Login.vue
index 35897bc41..5babc7f8f 100644
--- a/js/src/components/Account/Login.vue
+++ b/js/src/components/Account/Login.vue
@@ -110,24 +110,25 @@
       this.credentials.password = this.password;
     }
 
-    loginAction(e: Event) {
+    async loginAction(e: Event) {
       e.preventDefault();
 
-      this.$apollo.mutate({
-        mutation: LOGIN,
-        variables: {
-          email: this.credentials.email,
-          password: this.credentials.password,
-        },
-      }).then((result) => {
-        console.log(result)
+      try {
+        const result = await this.$apollo.mutate({
+          mutation: LOGIN,
+          variables: {
+            email: this.credentials.email,
+            password: this.credentials.password,
+          },
+        });
+
         this.saveUserData(result.data);
         this.$router.push({ name: 'Home' });
-      }).catch((e) => {
-        console.log(e);
+      } catch (err) {
+        console.error(err);
         this.error.show = true;
-        this.error.text = e.message;
-      });
+        this.error.text = err.message;
+      }
     }
 
     validEmail() {
@@ -136,7 +137,6 @@
 
     saveUserData({ login: login }) {
       localStorage.setItem(AUTH_USER_ID, login.user.id);
-      localStorage.setItem(AUTH_USER_ACTOR, JSON.stringify(login.actor));
       localStorage.setItem(AUTH_TOKEN, login.token);
     }
   }
diff --git a/js/src/graphql/auth.ts b/js/src/graphql/auth.ts
index 277343ec7..87d651faa 100644
--- a/js/src/graphql/auth.ts
+++ b/js/src/graphql/auth.ts
@@ -6,10 +6,6 @@ mutation Login($email: String!, $password: String!) {
     token,
     user {
       id,
-    },
-    actor {
-      avatarUrl,
-      preferredUsername,
     }
   },
 }

From 5dbd259e01d808332f3a169d8228dd2fa1097c43 Mon Sep 17 00:00:00 2001
From: Chocobozzz <me@florianbigard.com>
Date: Fri, 28 Dec 2018 16:30:35 +0100
Subject: [PATCH 3/3] Use includes instead of indexOf

---
 js/src/components/Account/Login.vue    | 5 +----
 js/src/components/Account/Register.vue | 2 +-
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/js/src/components/Account/Login.vue b/js/src/components/Account/Login.vue
index 5babc7f8f..cfc319cf6 100644
--- a/js/src/components/Account/Login.vue
+++ b/js/src/components/Account/Login.vue
@@ -92,10 +92,7 @@
     };
     rules = {
       required: value => !!value || 'Required.',
-      email: (value) => {
-        const pattern = /^(([^<>()[\]\\.,;:\s@"]+(\.[^<>()[\]\\.,;:\s@"]+)*)|(".+"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/;
-        return pattern.test(value) || 'Invalid e-mail.';
-      },
+      email: (value) => value.includes('@') || 'Invalid e-mail.',
     };
     user: any;
 
diff --git a/js/src/components/Account/Register.vue b/js/src/components/Account/Register.vue
index 7108b9484..114521dc7 100644
--- a/js/src/components/Account/Register.vue
+++ b/js/src/components/Account/Register.vue
@@ -123,7 +123,7 @@
     rules = {
       password_length: value => value.length > 6 || 'Password must be at least 6 characters long',
       required: value => !!value || 'Required.',
-      email: (value: string) => value.indexOf('@') !== -1 || 'Invalid e-mail.',
+      email: (value: string) => value.includes('@') || 'Invalid e-mail.',
     };
 
     resetState() {