Argument "physicalAddress" has invalid value $physicalAddress. In field "geom": Expected type "Point", found "". #27

Closed
opened 2023-11-25 09:58:10 +01:00 by cvu · 4 comments
Collaborator

Dieser Fehler kommt, wenn ich versuche eine neue Gruppe anzulegen und dann komme ich auch nicht weiter.

Argument "physicalAddress" has invalid value $physicalAddress. In field "geom": Expected type "Point", found "".

Dieser Fehler kommt, wenn ich versuche eine neue Gruppe anzulegen und dann komme ich auch nicht weiter. Argument "physicalAddress" has invalid value $physicalAddress. In field "geom": Expected type "Point", found "".
cvu added this to the Mobilizon 3 (abgeschlossen) milestone 2023-11-25 09:58:10 +01:00
cvu added the
help wanted
bug
labels 2023-11-25 09:58:10 +01:00
Collaborator

This is issue is a bit complicated:

  1. The error happen when trying to create a group without a (valid) address.
  2. After creating the group tho, we can edit it and remove the address!!

so one question is:
Do we want an Address to be a required field for creating Groups, or do we allow the creation of Groups without an Address?

This is issue is a bit complicated: 1. The error happen when trying to create a group without a (valid) address. 2. After creating the group tho, we can edit it and remove the address!! so one question is: Do we want an Address to be a required field for creating Groups, or do we allow the creation of Groups without an Address?
778a69cd added the
upstream
label 2023-11-25 17:26:31 +01:00
778a69cd removed this from the Mobilizon 3 (abgeschlossen) milestone 2023-11-25 17:27:15 +01:00
Collaborator

I made the address input required to create or update a Group, so that it's validated before submitting the request -> before running into the $physicalAddress invalid value error

I made the address input required to create or update a Group, so that it's validated before submitting the request -> before running into the $physicalAddress invalid value error
summersamara added the
needs testing on live
label 2023-11-28 10:52:49 +01:00
Collaborator

e4607567ce

This commit can not be upstreamed as it is just a "workaround":

The validation for group name and address fields is only done on the front-end, so it's possible for the user to create or update a group with an empty name and an empty address.

see #29

https://git.potsda.mn/potsda.mn/mobilizon/commit/e4607567cefa44688a17775db49bbd457cb602d8 This commit can not be upstreamed as it is just a "workaround": The validation for group name and address fields is only done on the front-end, so it's possible for the user to create or update a group with an empty name and an empty address. see https://git.potsda.mn/potsda.mn/mobilizon/issues/29
summersamara removed the
needs testing on live
label 2023-11-28 11:20:23 +01:00
Author
Collaborator

The problem seems to have been solved, but is it now always necessary to enter an address for new groups? What about groups that may not have a physical address?

The problem seems to have been solved, but is it now always necessary to enter an address for new groups? What about groups that may not have a physical address?
summersamara added the
needs testing on live
label 2023-12-08 19:20:22 +01:00
summersamara removed the
upstream
label 2023-12-09 16:50:51 +01:00
cvu closed this issue 2024-01-24 10:52:11 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: potsda.mn/mobilizon#27
No description provided.