potsda.mn/mobilizon

Fork 1

ICS instance feed is cutoff after a certain date #37

New issue

Closed

opened 2023-12-18 19:29:55 +01:00 by 778a69cd · 3 comments

778a69cd commented

2023-12-18 19:29:55 +01:00

Owner

We observe, that ICS instance feed for rotes.potsda.mn is currently cutoff right after this Event: https://rotes.potsda.mn/events/1067531a-0b3a-46f1-80c8-8a81dce6466d

That means the first event that we couldn't find in the feed (going by start date) is: https://rotes.potsda.mn/events/0c1f8f50-a7df-4e19-bc85-e2e8d7cbdac6

The logs look clean, so possibly this is a silent error that causes the feed to not be built further.

The feed doesn't seem to be generated in order of start date, so it might also look sense how the feed is ordered (probably event creation date) and look for anomalies in the first event that is not exported.

curl https://rotes.potsda.mn/feed/instance/ics

We observe, that ICS instance feed for rotes.potsda.mn is currently cutoff right after this Event: https://rotes.potsda.mn/events/1067531a-0b3a-46f1-80c8-8a81dce6466d That means the first event that we couldn't find in the feed (going by start date) is: https://rotes.potsda.mn/events/0c1f8f50-a7df-4e19-bc85-e2e8d7cbdac6 The logs look clean, so possibly this is a silent error that causes the feed to not be built further. The feed doesn't seem to be generated in order of start date, so it might also look sense how the feed is ordered (probably event creation date) and look for anomalies in the first event that is not exported. ``` curl https://rotes.potsda.mn/feed/instance/ics ```

778a69cd added the

bug

upstream

labels 2023-12-18 19:29:55 +01:00

summersamara commented

2023-12-19 23:35:46 +01:00

Collaborator

the ICS file always have 500 events.

see lib/service/export/icalendar.ex line: 15 there's the following statement:
@item_limit 500

the ICS file always have 500 events. see `lib/service/export/icalendar.ex line: 15` there's the following statement: `@item_limit 500`

😆 1

summersamara referenced this issue from a commit

2023-12-19 23:57:49 +01:00

Fix: order the fetched events for the ICS feed DESC by "beings_on"

summersamara referenced this issue from a commit

2023-12-20 00:27:14 +01:00

Supply sort and direction as arguments to list_public_local_events instead of hardcoding

summersamara commented

2023-12-20 02:16:05 +01:00

Collaborator

upstream MR https://framagit.org/framasoft/mobilizon/-/merge_requests/1512

summersamara added

needs testing on live

and removed

upstream

labels 2023-12-20 02:16:33 +01:00

778a69cd referenced this issue from a commit

2023-12-20 14:23:11 +01:00

Fix ICS feed missing events: order by "begins_on" DESC so that the latest events are always included

778a69cd commented

2023-12-20 14:40:19 +01:00

Author

Owner

This is great!
Upstream MR is already merged and I merged their stuff into our main and deployed that. Testing on https://test.rotes.potsda.mn/events/calendar looks well, so I think this issue is solved 🚀

This is great! Upstream MR is already merged and I merged their stuff into our `main` and deployed that. Testing on https://test.rotes.potsda.mn/events/calendar looks well, so I think this issue is solved 🚀

778a69cd closed this issue

2023-12-20 14:40:19 +01:00

778a69cd removed the

needs testing on live

label 2023-12-20 14:40:26 +01:00