From f1084c101fbb9d33d34614056b35e069c5e4e6ce Mon Sep 17 00:00:00 2001
From: Thomas Citharel <tcit@tcit.fr>
Date: Tue, 5 Dec 2023 07:59:06 +0100
Subject: [PATCH 1/5] fix(activitypub): fix receiving comments

Should fix race conditions and actors deleted of received comments

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
---
 lib/federation/activity_pub/transmogrifier.ex | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/lib/federation/activity_pub/transmogrifier.ex b/lib/federation/activity_pub/transmogrifier.ex
index 2963deacd..121d6a1bc 100644
--- a/lib/federation/activity_pub/transmogrifier.ex
+++ b/lib/federation/activity_pub/transmogrifier.ex
@@ -81,7 +81,14 @@ defmodule Mobilizon.Federation.ActivityPub.Transmogrifier do
                 object_data
                 |> transform_object_data_for_discussion()
                 |> save_comment_or_discussion()
+
+              {:ok, %Comment{} = comment} ->
+                # Object already exists
+                {:ok, nil, comment}
             end
+
+          {:error, err} ->
+            {:error, err}
         end
 
       {:ok, %Comment{} = comment} ->

From 89d1ee42f4577650ebf9b996a518019b2e0f373c Mon Sep 17 00:00:00 2001
From: Thomas Citharel <tcit@tcit.fr>
Date: Tue, 5 Dec 2023 08:06:16 +0100
Subject: [PATCH 2/5] fix(backend): handle ecto errors when fetching and create
 entities

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
---
 lib/federation/activity_pub/fetcher.ex | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/federation/activity_pub/fetcher.ex b/lib/federation/activity_pub/fetcher.ex
index 97166baa2..288c4a394 100644
--- a/lib/federation/activity_pub/fetcher.ex
+++ b/lib/federation/activity_pub/fetcher.ex
@@ -42,7 +42,7 @@ defmodule Mobilizon.Federation.ActivityPub.Fetcher do
   end
 
   @spec fetch_and_create(String.t(), Keyword.t()) ::
-          {:ok, map(), struct()} | {:error, atom()} | :error
+          {:ok, map(), struct()} | {:error, atom()} | {:error, Ecto.Changeset.t()} | :error
   def fetch_and_create(url, options \\ []) do
     case fetch(url, options) do
       {:ok, data} when is_map(data) ->
@@ -61,6 +61,9 @@ defmodule Mobilizon.Federation.ActivityPub.Fetcher do
             {:error, error} when is_atom(error) ->
               {:error, error}
 
+            {:error, %Ecto.Changeset{} = err} ->
+              {:error, err}
+
             :error ->
               {:error, :transmogrifier_error}
           end

From c4d2ec69ad4ba6fc1f631adaca26b58e9e6f24e8 Mon Sep 17 00:00:00 2001
From: Thomas Citharel <tcit@tcit.fr>
Date: Tue, 5 Dec 2023 08:14:43 +0100
Subject: [PATCH 3/5] fix(front): only show participants & announcements menu
 items to organizers

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
---
 src/components/Event/EventActionSection.vue | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/src/components/Event/EventActionSection.vue b/src/components/Event/EventActionSection.vue
index f094f8b4a..46bfb8a87 100644
--- a/src/components/Event/EventActionSection.vue
+++ b/src/components/Event/EventActionSection.vue
@@ -107,11 +107,7 @@
             {{ t("Actions") }}
           </o-button>
         </template>
-        <o-dropdown-item
-          aria-role="listitem"
-          has-link
-          v-if="canManageEvent || !event?.draft"
-        >
+        <o-dropdown-item aria-role="listitem" has-link v-if="canManageEvent">
           <router-link
             class="flex gap-1"
             :to="{
@@ -123,11 +119,7 @@
             {{ t("Participations") }}
           </router-link>
         </o-dropdown-item>
-        <o-dropdown-item
-          aria-role="listitem"
-          has-link
-          v-if="canManageEvent || !event?.draft"
-        >
+        <o-dropdown-item aria-role="listitem" has-link v-if="canManageEvent">
           <router-link
             class="flex gap-1"
             :to="{

From f81472e0818e85458307d1de5222ee9785ada1b1 Mon Sep 17 00:00:00 2001
From: Thomas Citharel <tcit@tcit.fr>
Date: Tue, 5 Dec 2023 08:28:11 +0100
Subject: [PATCH 4/5] fix(front): fix tag loading

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
---
 src/components/Event/TagInput.story.vue |  7 +------
 src/components/Event/TagInput.vue       | 10 ++++++++--
 src/composition/apollo/tags.ts          | 23 +++--------------------
 src/views/Event/EditView.vue            |  7 +------
 src/views/Posts/EditView.vue            |  3 +--
 5 files changed, 14 insertions(+), 36 deletions(-)

diff --git a/src/components/Event/TagInput.story.vue b/src/components/Event/TagInput.story.vue
index ed30e63e4..19bced808 100644
--- a/src/components/Event/TagInput.story.vue
+++ b/src/components/Event/TagInput.story.vue
@@ -1,7 +1,7 @@
 <template>
   <Story>
     <Variant title="new">
-      <TagInput v-model="tags" :fetch-tags="fetchTags" />
+      <TagInput v-model="tags" />
     </Variant>
     <!-- <Variant title="small">
       <TagInput v-model="tags" />
@@ -15,9 +15,4 @@ import { reactive } from "vue";
 import TagInput from "./TagInput.vue";
 
 const tags = reactive<ITag[]>([{ title: "Hello", slug: "hello" }]);
-
-const fetchTags = async () =>
-  new Promise<ITag[]>((resolve) => {
-    resolve([{ title: "Welcome", slug: "welcome" }]);
-  });
 </script>
diff --git a/src/components/Event/TagInput.vue b/src/components/Event/TagInput.vue
index a0fc7e7ac..d344524cd 100644
--- a/src/components/Event/TagInput.vue
+++ b/src/components/Event/TagInput.vue
@@ -34,10 +34,11 @@ import { ITag } from "../../types/tag.model";
 import debounce from "lodash/debounce";
 import { computed, onBeforeMount, ref } from "vue";
 import HelpCircleOutline from "vue-material-design-icons/HelpCircleOutline.vue";
+import { useFetchTags } from "@/composition/apollo/tags";
+import { FILTER_TAGS } from "@/graphql/tags";
 
 const props = defineProps<{
   modelValue: ITag[];
-  fetchTags: (text: string) => Promise<ITag[]>;
 }>();
 
 const emit = defineEmits(["update:modelValue"]);
@@ -56,9 +57,14 @@ const id = computed((): string => {
   return `tag-input-${componentId}`;
 });
 
+const { load: fetchTags } = useFetchTags();
+
 const getFilteredTags = async (newText: string): Promise<void> => {
   text.value = newText;
-  tags.value = await props.fetchTags(newText);
+  const res = await fetchTags(FILTER_TAGS, { filter: newText });
+  if (res) {
+    tags.value = res.tags;
+  }
 };
 
 const debouncedGetFilteredTags = debounce(getFilteredTags, 200);
diff --git a/src/composition/apollo/tags.ts b/src/composition/apollo/tags.ts
index 2eaa9341d..cd4bf7632 100644
--- a/src/composition/apollo/tags.ts
+++ b/src/composition/apollo/tags.ts
@@ -1,24 +1,7 @@
 import { FILTER_TAGS } from "@/graphql/tags";
 import { ITag } from "@/types/tag.model";
-import { apolloClient } from "@/vue-apollo";
-import { provideApolloClient, useLazyQuery } from "@vue/apollo-composable";
+import { useLazyQuery } from "@vue/apollo-composable";
 
-export async function fetchTags(text: string): Promise<ITag[]> {
-  try {
-    const { load: loadFetchTagsQuery } = useLazyQuery<
-      { tags: ITag[] },
-      { filter: string }
-    >(FILTER_TAGS);
-
-    const res = await provideApolloClient(apolloClient)(() =>
-      loadFetchTagsQuery(FILTER_TAGS, {
-        filter: text,
-      })
-    );
-    if (!res) return [];
-    return res.tags;
-  } catch (e) {
-    console.error(e);
-    return [];
-  }
+export function useFetchTags() {
+  return useLazyQuery<{ tags: ITag[] }, { filter: string }>(FILTER_TAGS);
 }
diff --git a/src/views/Event/EditView.vue b/src/views/Event/EditView.vue
index f146f9fdb..d833d8dea 100644
--- a/src/views/Event/EditView.vue
+++ b/src/views/Event/EditView.vue
@@ -56,11 +56,7 @@
             </option>
           </o-select>
         </o-field>
-        <tag-input
-          v-model="event.tags"
-          class="flex-1"
-          :fetch-tags="fetchTags"
-        />
+        <tag-input v-model="event.tags" class="flex-1" />
       </div>
 
       <o-field
@@ -626,7 +622,6 @@ import {
   useTimezones,
 } from "@/composition/apollo/config";
 import { useMutation } from "@vue/apollo-composable";
-import { fetchTags } from "@/composition/apollo/tags";
 import { Dialog } from "@/plugins/dialog";
 import { Notifier } from "@/plugins/notifier";
 import { useHead } from "@unhead/vue";
diff --git a/src/views/Posts/EditView.vue b/src/views/Posts/EditView.vue
index 74f8ac95c..e92d90525 100644
--- a/src/views/Posts/EditView.vue
+++ b/src/views/Posts/EditView.vue
@@ -32,7 +32,7 @@
           />
         </o-field>
 
-        <tag-input v-model="editablePost.tags" :fetch-tags="fetchTags" />
+        <tag-input v-model="editablePost.tags" />
 
         <o-field :label="t('Post')">
           <p v-if="errors.body" class="help is-danger">{{ errors.body }}</p>
@@ -158,7 +158,6 @@ import { useI18n } from "vue-i18n";
 import { computed, inject, onMounted, ref, watch } from "vue";
 import { useRouter } from "vue-router";
 import { useMutation, useQuery } from "@vue/apollo-composable";
-import { fetchTags } from "@/composition/apollo/tags";
 import { Dialog } from "@/plugins/dialog";
 
 const props = withDefaults(

From 147096cc3d17411c3cbd485b8dce2a90d3973e3e Mon Sep 17 00:00:00 2001
From: Thomas Citharel <tcit@tcit.fr>
Date: Tue, 5 Dec 2023 08:40:01 +0100
Subject: [PATCH 5/5] refactor: to lower cyclomatic complexity

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
---
 lib/federation/activity_pub/fetcher.ex        | 49 +++++++++++--------
 lib/federation/activity_pub/transmogrifier.ex | 24 +++++----
 2 files changed, 43 insertions(+), 30 deletions(-)

diff --git a/lib/federation/activity_pub/fetcher.ex b/lib/federation/activity_pub/fetcher.ex
index 288c4a394..b017256db 100644
--- a/lib/federation/activity_pub/fetcher.ex
+++ b/lib/federation/activity_pub/fetcher.ex
@@ -47,26 +47,7 @@ defmodule Mobilizon.Federation.ActivityPub.Fetcher do
     case fetch(url, options) do
       {:ok, data} when is_map(data) ->
         if origin_check?(url, data) do
-          case Transmogrifier.handle_incoming(%{
-                 "type" => "Create",
-                 "to" => data["to"],
-                 "cc" => data["cc"],
-                 "actor" => data["actor"] || data["attributedTo"],
-                 "attributedTo" => data["attributedTo"] || data["actor"],
-                 "object" => data
-               }) do
-            {:ok, entity, structure} ->
-              {:ok, entity, structure}
-
-            {:error, error} when is_atom(error) ->
-              {:error, error}
-
-            {:error, %Ecto.Changeset{} = err} ->
-              {:error, err}
-
-            :error ->
-              {:error, :transmogrifier_error}
-          end
+          pass_to_transmogrifier(data)
         else
           Logger.warning("Object origin check failed")
           {:error, :object_origin_check_failed}
@@ -101,6 +82,34 @@ defmodule Mobilizon.Federation.ActivityPub.Fetcher do
     end
   end
 
+  @spec pass_to_transmogrifier(map()) ::
+          {:ok, map(), struct()}
+          | {:error, atom()}
+          | {:error, Ecto.Changeset.t()}
+          | {:error, :transmogrifier_error}
+  defp pass_to_transmogrifier(data) do
+    case Transmogrifier.handle_incoming(%{
+           "type" => "Create",
+           "to" => data["to"],
+           "cc" => data["cc"],
+           "actor" => data["actor"] || data["attributedTo"],
+           "attributedTo" => data["attributedTo"] || data["actor"],
+           "object" => data
+         }) do
+      {:ok, entity, structure} ->
+        {:ok, entity, structure}
+
+      {:error, error} when is_atom(error) ->
+        {:error, error}
+
+      {:error, %Ecto.Changeset{} = err} ->
+        {:error, err}
+
+      :error ->
+        {:error, :transmogrifier_error}
+    end
+  end
+
   @type fetch_actor_errors ::
           :json_decode_error | :actor_deleted | :http_error | :actor_not_allowed_type
 
diff --git a/lib/federation/activity_pub/transmogrifier.ex b/lib/federation/activity_pub/transmogrifier.ex
index 121d6a1bc..4b64483b5 100644
--- a/lib/federation/activity_pub/transmogrifier.ex
+++ b/lib/federation/activity_pub/transmogrifier.ex
@@ -76,16 +76,7 @@ defmodule Mobilizon.Federation.ActivityPub.Transmogrifier do
             Actions.Create.create(:conversation, object_data, false)
 
           object_data when is_map(object_data) ->
-            case Discussions.get_comment_from_url_with_preload(object_data.url) do
-              {:error, :comment_not_found} ->
-                object_data
-                |> transform_object_data_for_discussion()
-                |> save_comment_or_discussion()
-
-              {:ok, %Comment{} = comment} ->
-                # Object already exists
-                {:ok, nil, comment}
-            end
+            handle_comment_or_discussion(object_data)
 
           {:error, err} ->
             {:error, err}
@@ -1026,6 +1017,19 @@ defmodule Mobilizon.Federation.ActivityPub.Transmogrifier do
       is_nil(object_data.title) or object_data.title == ""
   end
 
+  defp handle_comment_or_discussion(object_data) do
+    case Discussions.get_comment_from_url_with_preload(object_data.url) do
+      {:error, :comment_not_found} ->
+        object_data
+        |> transform_object_data_for_discussion()
+        |> save_comment_or_discussion()
+
+      {:ok, %Comment{} = comment} ->
+        # Object already exists
+        {:ok, nil, comment}
+    end
+  end
+
   # Comment and conversations have different attributes for actor and groups
   @spec transform_object_data_for_discussion(map()) :: map()
   defp transform_object_data_for_discussion(object_data) do